chore(trace-viewer): improve aria tab roles #37872
Closed
+16
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
| */ | ||
|
|
||
| .snapshot-tabs { | ||
| display: flex; |
There was a problem hiding this comment.
We only use vbox and hbox for flex containers. What do you mean by height: 100% in a flex parent?
There was a problem hiding this comment.
I'm not sure what you're questioning about height: 100%. flex does not fill the off dimension by default; you have to tell the element to expand to fit.
There was a problem hiding this comment.
Right, that's why we use vbox and hbox.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
pavelfeldman
approved these changes
Oct 20, 2025
|
Closing as stale to keep the review queue clean |
…race-viewer-aria-tab
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "MCP"2570 passed, 108 skipped Merge workflow run. |
Test results for "tests 1"1 failed 3 flaky47193 passed, 815 skipped Merge workflow run. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses microsoft/playwright.dev#1806 and microsoft/playwright.dev#1807